Use WebAssembly version libraries for unit testing #16264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinktofit
force-pushed
the
UnitTestWasm
branch
from
2848853
to
87c38fe
Compare
Interface Check ReportThis pull request does not change any public interfaces ! |
shrinktofit
force-pushed
the
UnitTestWasm
branch
from
44e6676
to
165bbfd
Compare
PPpro
reviewed
Sep 18, 2023
Comment on lines
+29
to
+53
| export async function instantiateWasm (wasmUrl: string, importObject: WebAssembly.Imports): Promise<any> { | ||
| return fetchBuffer(wasmUrl).then((arrayBuffer) => WebAssembly.instantiate(arrayBuffer, importObject)); | ||
| } | ||
|
|
||
| export async function fetchBuffer (binaryUrl: string): Promise<ArrayBuffer> { | ||
| const relativePathToExternal = /^external:(.*)/.exec(binaryUrl)?.[1]; | ||
| if (relativePathToExternal) { | ||
| const externalHome = join(__dirname, '..', '..', 'native', 'external'); | ||
| const path = join(externalHome, relativePathToExternal); | ||
| try { | ||
| const content = readFileSync(path); | ||
| return content.buffer; | ||
| } catch (err) { | ||
| throw new Error(`Unable to fetch buffer from ${binaryUrl}`, { cause: error }); | ||
| } | ||
| } | ||
|
|
||
| throw new Error(`Don't know how to fetch buffer at url ${binaryUrl}`); | ||
| } | ||
|
|
||
| export async function ensureWasmModuleReady() { | ||
| return Promise.resolve(); | ||
| } | ||
|
|
||
| checkPalIntegrity<typeof import('@pal/wasm')>(withImpl<typeof import('./pal-wasm-testing')>()); |
There was a problem hiding this comment.
It makes it possible to use wasm in unit test.
There was a problem hiding this comment.
why don't actually mock pal/wasm module to the web implementation
|
and please remember to update the related docs https://github.com/cocos/3d-tasks/blob/master/design-docs/scripting/engine-wasm-module.md#%E8%A7%A3%E5%86%B3-ci-%E9%97%AE%E9%A2%98 |
PPpro
approved these changes
Sep 18, 2023
lealzhan
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: